ci: try to fix podman tests by building proto once #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9267 +/- ##
==========================================
- Coverage 44.59% 44.58% -0.02%
==========================================
Files 1273 1273
Lines 155832 155832
Branches 2439 2438 -1
==========================================
- Hits 69501 69472 -29
- Misses 86092 86121 +29
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more. |
NicholasBlaskey
changed the title
dannysauer
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
There have been some other questionable things recently where workspace data seems to be different in later steps after rebuilds, and rebuilding things repeatedly is part of why our tests are so dang slow to begin with. Thanks for this; hopefully it helps. :)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Fix failing podman tests
https://app.circleci.com/pipelines/github/determined-ai/determined/54910/workflows/19816278-7088-4c7e-910e-5a6c50699a96/jobs/2515396
Don't build proto again. We probably shouldn't be building proto more than once per CI. We also likely don't even need to build
protoat all. My best guess of what is going on is somehow thestore_artifactsis interacting weirdly with us building proto again so try making sure we always run after build proto is done.Test Plan
Tests pass on main after landing
Checklist
docs/release-notes/.See Release Note for details.