-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: users can be removed from all groups in Web UI #9259
Conversation
Co-authored-by: Amanda Vialva <amanda.vialva@hpe.com>
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9259 +/- ##
==========================================
- Coverage 44.69% 37.95% -6.75%
==========================================
Files 1270 946 -324
Lines 155186 115571 -39615
Branches 2435 2436 +1
==========================================
- Hits 69368 43866 -25502
+ Misses 85582 71469 -14113
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we do this with something like disabled: _.isEqual(userGroups, groupsValue)
to still prevent submitting when no changes are made while allowing an empty array value?
Good idea, @johnkim-det. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the change
Co-authored-by: Amanda Vialva <amanda.vialva@hpe.com> (cherry picked from commit 86328cb)
Ticket
DET-10246
Description
Validation was keeping us from removing all groups from a user in the Web UI. This fixes that.
Test Plan
/admin/user-management
)det user-group describe GroupName
(substituting the real group name you chose into the command)Checklist