Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix master config doc typo #9256

Merged
merged 1 commit into from
May 1, 2024
Merged

docs: fix master config doc typo #9256

merged 1 commit into from
May 1, 2024

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Apr 26, 2024 •
edited by jira bot
Loading

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 26, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 26, 2024
@determined-ci determined-ci requested a review from a team April 26, 2024 18:46
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0f75edb
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/662bf6812ee83a000864129d
😎 Deploy Preview https://deploy-preview-9256--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgongd jgongd marked this pull request as ready for review April 26, 2024 18:46
@jgongd jgongd requested a review from tara-det-ai April 26, 2024 19:22
tara-det-ai
tara-det-ai approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgongd jgongd merged commit b602ff2 into main May 1, 2024
90 of 102 checks passed
@jgongd jgongd deleted the jgong/doc-fix-master-config-typo branch May 1, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgongd @tara-det-ai @determined-ci