Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: undo default log retention in values.yaml #9245

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 25, 2024

Ticket

Description

Test Plan

make sure tests pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 1780c6e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/662aaaccb8e1ab0008390e5f

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.72%. Comparing base (4d20fae) to head (1780c6e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9245   +/-   ##
=======================================
  Coverage   44.71%   44.72%           
=======================================
  Files        1270     1270           
  Lines      155328   155328           
  Branches     2436     2436           
=======================================
+ Hits        69461    69467    +6     
+ Misses      85631    85625    -6     
  Partials      236      236           
Flag Coverage Δ
backend 41.66% <ø> (+0.01%) ⬆️
harness 64.28% <ø> (ø)
web 35.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@salonig23 salonig23 marked this pull request as ready for review April 25, 2024 19:58
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Personally I would make this a chore: so we don't need to test this in the release party

@salonig23 salonig23 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 25, 2024
@salonig23 salonig23 merged commit 95e4257 into main Apr 25, 2024
126 checks passed
@salonig23 salonig23 deleted the log-retention-helm branch April 25, 2024 20:56
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@salonig23 salonig23 changed the title fix: undo default log retention in values.yaml chore: undo default log retention in values.yaml Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants