Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report ntsc names via cli when launched #9228

Merged
merged 4 commits into from
May 15, 2024
Merged

chore: report ntsc names via cli when launched #9228

merged 4 commits into from
May 15, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Apr 23, 2024

Ticket

https://hpe-aiatscale.atlassian.net/browse/RM-263
https://hpe-aiatscale.atlassian.net/issues/MD-412?filter=10316

Description

also remove a duplicate get for shells

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 23, 2024
Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6632068
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6644f7911ef4bb0008f3cafa

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 45.29%. Comparing base (53edec9) to head (08c2d94).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9228      +/-   ##
==========================================
+ Coverage   45.28%   45.29%   +0.01%     
==========================================
  Files        1227     1227              
  Lines      154095   154096       +1     
  Branches     2403     2404       +1     
==========================================
+ Hits        69782    69804      +22     
+ Misses      84121    84100      -21     
  Partials      192      192              
Flag Coverage Δ
backend 41.80% <ø> (+0.04%) ⬆️
harness 64.10% <16.66%> (-0.01%) ⬇️
web 36.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/cli/notebook.py 28.88% <0.00%> (ø)
harness/determined/cli/render.py 52.97% <50.00%> (ø)
harness/determined/cli/tensorboard.py 30.23% <0.00%> (ø)
harness/determined/cli/shell.py 23.42% <0.00%> (+0.20%) ⬆️
harness/determined/cli/command.py 43.47% <20.00%> (+0.62%) ⬆️

... and 6 files with indirect coverage changes

@hamidzr hamidzr marked this pull request as ready for review April 24, 2024 16:16
@hamidzr hamidzr requested a review from a team as a code owner April 24, 2024 16:16
@hamidzr hamidzr requested a review from jgongd April 24, 2024 16:16
@jgongd
Copy link
Contributor

jgongd commented Apr 25, 2024

I like this. The name could be handy.

Comment on lines +37 to +38
assert self.task_id is not None, "Task ID could not be found"
assert self.task_name is not None, "Task name could not be found"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why weren't we checking these before 🤔 can the assumption be incorrect somewhere?

@hamidzr hamidzr merged commit 7bce6ff into main May 15, 2024
83 of 96 checks passed
@hamidzr hamidzr deleted the hz-incl-name branch May 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants