-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: report ntsc names via cli when launched #9228
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9228 +/- ##
==========================================
+ Coverage 45.28% 45.29% +0.01%
==========================================
Files 1227 1227
Lines 154095 154096 +1
Branches 2403 2404 +1
==========================================
+ Hits 69782 69804 +22
+ Misses 84121 84100 -21
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I like this. The name could be handy. |
assert self.task_id is not None, "Task ID could not be found" | ||
assert self.task_name is not None, "Task name could not be found" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why weren't we checking these before 🤔 can the assumption be incorrect somewhere?
Ticket
https://hpe-aiatscale.atlassian.net/browse/RM-263
https://hpe-aiatscale.atlassian.net/issues/MD-412?filter=10316
Description
also remove a duplicate get for shells
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.