Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log retention to helm charts #9216

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 22, 2024

Ticket

Description

Test Plan

Make sure all tests pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 22, 2024
@determined-ci determined-ci requested a review from a team April 22, 2024 18:19
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 04d432e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6627db4c97fffc00084a509f

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.72%. Comparing base (1b212ae) to head (04d432e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9216   +/-   ##
=======================================
  Coverage   44.72%   44.72%           
=======================================
  Files        1266     1266           
  Lines      154770   154770           
  Branches     2438     2439    +1     
=======================================
  Hits        69225    69225           
  Misses      85313    85313           
  Partials      232      232           
Flag Coverage Δ
backend 41.57% <ø> (ø)
harness 64.14% <ø> (ø)
web 35.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@salonig23 salonig23 marked this pull request as ready for review April 22, 2024 19:00
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salonig23 salonig23 merged commit 3b39d3c into main Apr 24, 2024
114 of 116 checks passed
@salonig23 salonig23 deleted the add-log-retention-helm branch April 24, 2024 00:01
@salonig23 salonig23 changed the title chore: add log retention to help charts chore: add log retention to helm charts Apr 24, 2024
@salonig23 salonig23 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants