-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add log retention to helm charts #9216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
salonig23
force-pushed
the
add-log-retention-helm
branch
from
April 22, 2024 18:36
4105c05
to
baa2818
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9216 +/- ##
=======================================
Coverage 44.72% 44.72%
=======================================
Files 1266 1266
Lines 154770 154770
Branches 2438 2439 +1
=======================================
Hits 69225 69225
Misses 85313 85313
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. |
tara-det-ai
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maxrussell
approved these changes
Apr 23, 2024
hkumar92
approved these changes
Apr 23, 2024
salonig23
changed the title
chore: add log retention to help charts
chore: add log retention to helm charts
Apr 24, 2024
salonig23
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
documentation
Improvements or additions to documentation
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Test Plan
Make sure all tests pass
Checklist
docs/release-notes/
.See Release Note for details.