Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shared cluster test to work in OSS again #9195

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

amandavialva01
Copy link
Contributor

Ticket

Description

This PR removes the changes made to the GKE shared cluster testing that allowed it to run successfully in the EE repo.

Test Plan

CI Passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.43%. Comparing base (dd7f4b5) to head (4834c24).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9195      +/-   ##
==========================================
- Coverage   45.92%   40.43%   -5.49%     
==========================================
  Files         777      749      -28     
  Lines      107000   105219    -1781     
  Branches     2437     2438       +1     
==========================================
- Hits        49137    42546    -6591     
- Misses      57631    62441    +4810     
  Partials      232      232              
Flag Coverage Δ
backend 34.27% <ø> (ø)
harness 49.53% <ø> (-14.49%) ⬇️
web 35.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 162 files with indirect coverage changes

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4834c24
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6622c981035b420008c9f183

Copy link
Contributor

@eecsliu eecsliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes and lgtm! Nice work!

@amandavialva01 amandavialva01 force-pushed the amanda/removeLicenseFromSharedCluster branch from 7156eb3 to 4834c24 Compare April 19, 2024 19:43
@eecsliu
Copy link
Contributor

eecsliu commented Apr 19, 2024

My review still stands :) as long as the test passes feel free to merge!

@amandavialva01 amandavialva01 merged commit bd4a54e into main Apr 20, 2024
78 of 96 checks passed
@amandavialva01 amandavialva01 deleted the amanda/removeLicenseFromSharedCluster branch April 20, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants