feat: Use feature flag for streaming updates #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9170 +/- ##
==========================================
- Coverage 40.43% 38.71% -1.72%
==========================================
Files 749 875 +126
Lines 105220 108235 +3015
Branches 2438 2439 +1
==========================================
- Hits 42548 41908 -640
- Misses 62440 66095 +3655
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gt2345
force-pushed
the
gt/369-streaming-updates-flag
branch
from
e113263
to
f3a7536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
MD-369
Description
Sometime the backend may not support streaming updates, so we can create a flag at WebUI to disable and enable streaming updates.
When streaming updates flag is false, we skip connecting to web socket during start up, and at the project list page, we manually update the store when patchProject happens.
Test Plan
With streaming_updates flag on and off, navigate to project list page.
Create/edit/delete project should work as expected.
Checklist
docs/release-notes/.See Release Note for details.