Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset table offset when filtering for models #9167

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Apr 15, 2024

Ticket

MD-362

Description

When filters change for model registry table, reset table offset to avoid API error.

Test Plan

When model registry table is over 1 page, navigate to page 2+, apply filters to table (name, tags, workspace...), and the table should auto reset to the first page.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@gt2345 gt2345 requested a review from a team as a code owner April 15, 2024 17:41
@gt2345 gt2345 requested a review from EmilyBonar April 15, 2024 17:41
@cla-bot cla-bot bot added the cla-signed label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 39.00%. Comparing base (8a94574) to head (04803ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9167      +/-   ##
==========================================
- Coverage   45.72%   39.00%   -6.72%     
==========================================
  Files        1179      857     -322     
  Lines      146795   107393   -39402     
  Branches     2420     2419       -1     
==========================================
- Hits        67123    41893   -25230     
+ Misses      79458    65286   -14172     
  Partials      214      214              
Flag Coverage Δ
harness ?
web 35.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ModelRegistry.tsx 0.00% <0.00%> (ø)

... and 322 files with indirect coverage changes

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 04803ac
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/661d66c8fcc4640008a107ff
😎 Deploy Preview https://deploy-preview-9167--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gt2345 gt2345 merged commit d38fc3c into main Apr 16, 2024
78 of 90 checks passed
@gt2345 gt2345 deleted the gt/362-model-filter branch April 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants