-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add release notes for 0.30.0 #9103
Conversation
Docsite preview being generated for this PR. |
Docsite preview being generated for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.30.0 #9103 +/- ##
==================================================
- Coverage 47.43% 43.43% -4.01%
==================================================
Files 1165 723 -442
Lines 143670 102030 -41640
Branches 2347 2349 +2
==================================================
- Hits 68151 44312 -23839
+ Misses 75360 57559 -17801
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
||
- Database migration: system metrics collected by the Determined profiler are now stored in the | ||
generic ``metrics`` table. This requires a few schema changes to the ``metrics`` table that will | ||
be run during migrations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Database migration: System metrics...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others too, don't forget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalized!
.. important:: | ||
|
||
This migration will be more time-consuming for deployments with a large amount of metrics stored. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. important::
This migration may take more time for deployments with a large amount of stored metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
docs/release-notes.rst
Outdated
**New Features** | ||
|
||
- Core API: the Determined profiler is now accessible from the Core API. It collects system | ||
metrics, which can be viewed in the Web UI under the experiment's "Profiler" tab. See the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebUI (rather than "Web UI")
|
||
- Core API: the Determined profiler is now accessible from the Core API. It collects system | ||
metrics, which can be viewed in the Web UI under the experiment's "Profiler" tab. See the | ||
:ref:`Core API guide <core-profiler>` for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this page exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! It points here: model-dev-guide/api-guides/apis-howto/api-core-ug.html#core-profiler
docs/release-notes.rst
Outdated
:ref:`training API <apis-howto-overview>` for this functionality. | ||
|
||
- Historical data for timing metrics is retained in the ``trial_profiler_metrics`` database | ||
table, but they are no longer being collected or rendered in the Web UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebUI
docs/release-notes.rst
Outdated
|
||
- Historical data for system metrics generated by trials before this release are not | ||
automatically migrated due to time cost. For users wanting to view historical system metrics | ||
in the Web UI, we provide an `optional migration script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added suggestions for consistency
docs/release-notes.rst
Outdated
generic ``metrics`` table. This requires a few schema changes to the ``metrics`` table that will | ||
be run during migrations. | ||
|
||
.. important:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent so it's part of the list item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/release-notes.rst
Outdated
|
||
**Removed Features** | ||
|
||
- Profiler: support for timing metrics and related configurations have been removed. The Determined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Profiler: support for timing metrics and related configurations have been removed. The Determined | |
- Profiler: Support for timing metrics and related configurations has been removed. The Determined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
|
||
- Database migration: system metrics collected by the Determined profiler are now stored in the | ||
generic ``metrics`` table. This requires a few schema changes to the ``metrics`` table that will | ||
be run during migrations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others too, don't forget.
Docsite preview being generated for this PR. |
release notes for 0.30.0 (cherry picked from commit 97aaa02)
Add release notes for 0.30.0.