Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure that the genai helm chart services work across namespaces #9102

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

tayritenour
Copy link
Contributor

Description

When using genai on k8s clusters that use different namespaces for their resources pools, the existing services could not be resolved without specifying the k8s namespace that it was created in.

Test Plan

Should not need manual testing from release party.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit afa1cfe
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660dc11b471ca60008bdcad0

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.78%. Comparing base (943b2cb) to head (afa1cfe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9102      +/-   ##
==========================================
+ Coverage   46.77%   46.78%   +0.01%     
==========================================
  Files        1155     1155              
  Lines      142469   142469              
  Branches     2385     2387       +2     
==========================================
+ Hits        66633    66658      +25     
+ Misses      75646    75621      -25     
  Partials      190      190              
Flag Coverage Δ
backend 43.10% <ø> (+0.05%) ⬆️
harness 64.07% <ø> (ø)
web 38.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@tybritten tybritten self-requested a review April 3, 2024 22:54
@tayritenour tayritenour enabled auto-merge (squash) April 3, 2024 22:55
Copy link
Contributor

@tybritten tybritten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tayritenour tayritenour merged commit bc8c31c into main Apr 3, 2024
75 of 87 checks passed
@tayritenour tayritenour deleted the genai_services_fix branch April 3, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants