Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match GetJobQueueStats behavior in k8s RM to agent RM [RM-136] #9097

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

carolinaecalderon
Copy link
Contributor

Description

Match RM behavior for GetJobQueueStats in the kubernetes implementation of the interface to the agent implementation. Add a clause to filter in resource pools in the included stats.

Test Plan

See new tests for the agentRM & k8sRM -- without my changes to the code these tests would pass only for agent RM & fail in k8s.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

RM-136

@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d371ff6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6610072014ec7c00081c7bce

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.68%. Comparing base (2ef5ab9) to head (d371ff6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9097      +/-   ##
==========================================
+ Coverage   46.63%   46.68%   +0.04%     
==========================================
  Files        1172     1172              
  Lines      143619   143621       +2     
  Branches     2410     2410              
==========================================
+ Hits        66983    67044      +61     
+ Misses      76431    76372      -59     
  Partials      205      205              
Flag Coverage Δ
backend 43.52% <100.00%> (+0.13%) ⬆️
harness 63.99% <ø> (ø)
web 37.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 28.47% <100.00%> (+5.02%) ⬆️

... and 6 files with indirect coverage changes

@carolinaecalderon carolinaecalderon marked this pull request as ready for review April 3, 2024 19:42
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner April 3, 2024 19:42
@carolinaecalderon carolinaecalderon self-assigned this Apr 3, 2024
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carolinaecalderon carolinaecalderon merged commit a0847b8 into main Apr 5, 2024
72 of 84 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/rm-136 branch April 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants