chore: better k8s testing #9074
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9074 +/- ##
==========================================
- Coverage 46.64% 46.64% -0.01%
==========================================
Files 1172 1172
Lines 143619 143619
Branches 2410 2410
==========================================
- Hits 66985 66984 -1
- Misses 76429 76430 +1
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more. |
amandavialva01
force-pushed
the
amanda/shortenBuildAndPush
branch
from
af0eba5
to
d0c1d2b
Compare
helm/charts/determined/values.yaml
Outdated
| @@ -233,6 +240,10 @@ checkpointStorage: | |||
| # the greatest common divisor of all the sizes (4, in that case). | |||
| maxSlotsPerPod: | |||
|
|
|||
|
|
|||
| # TODO( POPULATE THIS COMMENT) | |||
There was a problem hiding this comment.
Again, another remnant from the WIP branch
| # TODO( POPULATE THIS COMMENT) | |
| # Flag for determining whether or not to create the cluster-scoped objects, when deploying multiple namespaces within the same cluster, should be set to false. |
There was a problem hiding this comment.
It looks like this might be redundant
There was a problem hiding this comment.
We use createNonNamespacedObjects for the cluster deployment script when deciding whether to create priority classes
There was a problem hiding this comment.
Gah, update on this: I didn't realize I redefined that field, we need createNonNamespacedObjects: true for the longrunning tests since they spinup a new cluster. Resolved here!
amandavialva01
force-pushed
the
amanda/shortenBuildAndPush
branch
from
9380504
to
d6a438f
Compare
amandavialva01
force-pushed
the
amanda/shortenBuildAndPush
branch
from
edda6c8
to
222affc
Compare
amandavialva01
force-pushed
the
amanda/shortenBuildAndPush
branch
from
8940f41
to
876db4d
Compare
| @@ -56,6 +56,9 @@ stringData: | |||
| {{- end }} | |||
| security: | |||
| {{- if .Values.initialUserPassword }} | |||
| initial_user_password: {{ .Values.initialUserPassword | quote }} | |||
There was a problem hiding this comment.
omg, just rebased to this and -- thanks!! Saves me some work on DET-10208 I think!
Description
With this PR, CI instances can run e2e tests on a shared GKE cluster.
This moves GKE tests out of long-running since we push the docker image in a shorter job and no longer need to wait for cluste setup and tear down, while also providing the added benefit of being able to view test failures that persist on the master service deployment that was helm installed onto the remote cluster.
Test Plan
CI passes.
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-10075, DET-10077, DET-10135, DET-10189