Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing issue with exp list pagination #9067

Merged
merged 69 commits into from
Apr 1, 2024
Merged

fix: spacing issue with exp list pagination #9067

merged 69 commits into from
Apr 1, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Mar 28, 2024

Description

Minor follow up to #8956. Adding back spacing between Pagination component and DataGrid when infinite scroll is off.

Test Plan

Follow up to refactor PR, should not require additional testing for release.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@johnkim-det johnkim-det requested a review from a team as a code owner March 28, 2024 14:56
@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
@johnkim-det johnkim-det removed the request for review from keita-determined March 28, 2024 14:56
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 15b56fa
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6607491365023400083f649c
😎 Deploy Preview https://deploy-preview-9067--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.63%. Comparing base (85bb3c8) to head (15b56fa).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9067      +/-   ##
==========================================
- Coverage   47.18%   40.63%   -6.55%     
==========================================
  Files        1152      831     -321     
  Lines      141773   102581   -39192     
  Branches     2417     2417              
==========================================
- Hits        66890    41685   -25205     
+ Misses      74693    60706   -13987     
  Partials      190      190              
Flag Coverage Δ
harness ?
web 38.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 321 files with indirect coverage changes

Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the gap not work if you wrap pagination in a row? having a spacer element seems yucky.

@johnkim-det
Copy link
Contributor Author

does the gap not work if you wrap pagination in a row? having a spacer element seems yucky.

gap for row only works if there are multiple child elements, realized it makes more sense to have the gap applied to the wrapper

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnkim-det johnkim-det merged commit 3f2d6ab into main Apr 1, 2024
69 of 81 checks passed
@johnkim-det johnkim-det deleted the ET-25 branch April 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants