refactor: change GlideTable into a reusable component (ET-25) #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8956 +/- ##
==========================================
- Coverage 47.78% 40.72% -7.07%
==========================================
Files 1161 734 -427
Lines 143441 96297 -47144
Branches 2372 2401 +29
==========================================
- Hits 68547 39219 -29328
+ Misses 74741 56894 -17847
- Partials 153 184 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashtonG
reviewed
Mar 20, 2024
ashtonG
approved these changes
Mar 20, 2024
EmilyBonar
approved these changes
Mar 27, 2024
| sorts={sorts} | ||
| staticColumns={STATIC_COLUMNS} | ||
| total={Loadable.getOrElse(PAGE_SIZE, total)} |
There was a problem hiding this comment.
fix: isPagedView ? runs.length : Loadable.getOrElse(PAGE_SIZE, total)
There was a problem hiding this comment.
actually should not need this for total since it's only used when isPaginated is false, and DataGrid already sets the correct value for rows if isPaginated
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will update to remove
glide-tablefolder and useDataGridfrom hew when that's merged in that repo.also will include fix for ET-63
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket