Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CODEOWNERS deploy owned by RM not MD #9064

Merged
merged 2 commits into from
Apr 1, 2024
Merged

chore: CODEOWNERS deploy owned by RM not MD #9064

merged 2 commits into from
Apr 1, 2024

Conversation

wes-turner
Copy link
Contributor

@wes-turner wes-turner commented Mar 27, 2024 •
edited
Loading

  • Comment had stated that harness/determined/deploy was unknowned (though it actually had been owned by MD). Made it owned by RM
  • Comment had stated that harness/determined/cli was unknowned. Removed the comment.

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@wes-turner wes-turner requested a review from a team as a code owner March 27, 2024 21:43
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2024
@wes-turner wes-turner requested a review from stoksc March 27, 2024 21:43
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 3e4b5b2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660590124ae5ac0008d288f5

@wes-turner
chore: CODEOWNERS model-dev doesn't own deploy
8996cc3 
* Comment had stated that `harness/determined/deploy` was unknowned.
  Actually made it so.

* Comment had stated that `harness/determined/cli` was unknowned.
  Removed the comment.
stoksc
stoksc reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add resource mgmt please?

@wes-turner
Copy link
Contributor Author

can you add resource mgmt please?

Done

@wes-turner wes-turner changed the title chore: CODEOWNERS model-dev doesn't own deploy chore: CODEOWNERS deploy owned by RM not MD Mar 28, 2024
@wes-turner wes-turner merged commit fe66b86 into main Apr 1, 2024
67 of 79 checks passed
@wes-turner wes-turner deleted the wes/deploy-unowned branch April 1, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc left review comments

@loksonarius loksonarius loksonarius approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wes-turner @loksonarius @stoksc