docs: update multiRM docs #9050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
carolinaecalderon
requested review from
stoksc,
NicholasBlaskey and
tara-det-ai
tara-det-ai
reviewed
Mar 26, 2024
carolinaecalderon
changed the title
carolinaecalderon
force-pushed
the
carolinac/multirm-docs
branch
from
4458ef5
to
de14288
Compare
carolinaecalderon
changed the base branch from
main
to
carolinac/revert-multirm-docs
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9050 +/- ##
==========================================
+ Coverage 47.07% 47.73% +0.65%
==========================================
Files 1155 1167 +12
Lines 142400 143894 +1494
Branches 2421 2379 -42
==========================================
+ Hits 67034 68685 +1651
+ Misses 75176 75050 -126
+ Partials 190 159 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
tara-det-ai
reviewed
Apr 2, 2024
| @@ -8,7 +8,8 @@ | |||
| ``additional_resource_managers`` and ``resource_pools`` (additional resource managers are | |||
| required to have at least one resource pool defined). Additional resource managers and their | |||
| resource pools must have unique names. For more information, visit :ref:master configuration | |||
| <master-config-reference>. | |||
| <master-config-reference>. Support for notebooks and other workloads that require proxying is | |||
| currently under development. | |||
There was a problem hiding this comment.
if we can, we should avoid saying "currently under development" in the release notes
There was a problem hiding this comment.
just "under development"? or what do you suggest?
carolinaecalderon
force-pushed
the
carolinac/multirm-docs
branch
from
06e164f
to
47bf9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted
"Reverted" with #9144
Description
Add multiRM docs, and mention that notebook/proxied workload support is coming, but not available yet.
Test Plan
Commentary (optional)
At the moment, this PR is compared against #9053, just because we're going to merge the PR that reverts the docs first
Checklist
docs/release-notes/.See Release Note for details.
Ticket