Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Describe multi rm k8s #9025

Merged
merged 9 commits into from
Apr 19, 2024
Merged

docs: Describe multi rm k8s #9025

merged 9 commits into from
Apr 19, 2024

Conversation

tara-det-ai
Copy link
Member

@tara-det-ai tara-det-ai commented Mar 20, 2024

##Description

Feature: Multiple Resource Managers for Kubernetes.
Docs: Add/Update the following:

  • /reference/deploy/helm-config-reference
  • /reference/deploy/master-config-reference
  • /release-notes/multirm-for-k8s
  • setup-cluster/k8s/setup-multiple-resource-managers

Related

#9050
#9122
#9119

Add a New Page to the K8S Setup Section

  • Tentative title "Configure Multiple Resource Managers"
  • Draft docs page for describing how to work with and manage multiple resource managers for kubernetes installations.
  • Target audience: admin.
  • Target release date: Not tied to a release.

For starters, we need to add examples mentioned here in #9016:
https://github.com/determined-ai/determined/pull/9016/files#r1532170203

  • Walk through an example
    • e.g., Setting kubeconfig
    • e.g., Setting masterip/port for the different resource managers
    • Example of doing multicloud or multi gke cluster.

@cla-bot cla-bot bot added the cla-signed label Mar 20, 2024
@determined-ci determined-ci requested a review from a team March 20, 2024 15:19
@tara-det-ai tara-det-ai removed the request for review from a team March 20, 2024 15:19
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit dcc9811
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66227f060f4616000848c1ae
😎 Deploy Preview https://deploy-preview-9025--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Mar 20, 2024
@tara-det-ai tara-det-ai marked this pull request as draft March 20, 2024 15:19
@determined-ci determined-ci requested a review from a team March 21, 2024 00:05
@tara-det-ai tara-det-ai force-pushed the docs/Describe-multi-rm-k8s branch 3 times, most recently from 41296be to 4570686 Compare April 8, 2024 18:30
@tara-det-ai tara-det-ai marked this pull request as ready for review April 16, 2024 19:05
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.49%. Comparing base (598784d) to head (dcc9811).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9025      +/-   ##
==========================================
- Coverage   45.96%   40.49%   -5.47%     
==========================================
  Files         779      627     -152     
  Lines      107162    95315   -11847     
  Branches     2438     2438              
==========================================
- Hits        49258    38602   -10656     
+ Misses      57672    56481    -1191     
  Partials      232      232              
Flag Coverage Δ
harness 53.12% <ø> (-11.05%) ⬇️
web 35.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 216 files with indirect coverage changes

@tara-det-ai tara-det-ai merged commit f74ab9c into main Apr 19, 2024
80 of 97 checks passed
@tara-det-ai tara-det-ai deleted the docs/Describe-multi-rm-k8s branch April 19, 2024 18:26
JComins000 pushed a commit that referenced this pull request Apr 22, 2024
Co-authored-by: Carolina Calderon <carolina.calderon@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants