ci: tag CI-deployed resources #9043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the owner and gh_team tags the new tagging policy requires Also add the long_running tag to the long-running instances
Update the Makefile to work with current terraform Update the CircleCI image to use one which still gets updates Update the docs AWS resources with new label standard * To use aws default_labels, we need the 5.x AWS provider * To use the 5.x provider without a bunch of warnings, there were also a bunch of deprecated things to be updated
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9043 +/- ##
==========================================
- Coverage 47.80% 47.80% -0.01%
==========================================
Files 1161 1161
Lines 143646 143646
Branches 2371 2373 +2
==========================================
- Hits 68674 68672 -2
- Misses 74819 74821 +2
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. |
4 tasks
loksonarius
approved these changes
Mar 23, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the owner and gh_team tags the new tagging policy requires Also add the long_running tag to the long-running instances
Test Plan
See what happens in CI; react accordingly.
Commentary (optional)
The terraform image used for doc publishing is switched from light to latest because the light tag is no longer maintained as of over a year ago.
hashicorp/terraform#33139
I've already imported, planned, and reapplied the updated Terraform files. So this should just work cleanly without needing to recreate objects, etc.
Supersedes #8969
Checklist
docs/release-notes/.See Release Note for details.
Ticket