Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: helm for multirm kubeconfig_path #9033

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

NicholasBlaskey
Copy link
Contributor

Description

See #9015

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ef3891a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65fc3c7f4fd0820008ace362

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.82%. Comparing base (4441d6d) to head (ef3891a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9033      +/-   ##
==========================================
+ Coverage   47.81%   47.82%   +0.01%     
==========================================
  Files        1161     1161              
  Lines      143646   143646              
  Branches     2373     2371       -2     
==========================================
+ Hits        68682    68701      +19     
+ Misses      74811    74792      -19     
  Partials      153      153              
Flag Coverage Δ
backend 43.01% <ø> (+0.04%) ⬆️
harness 63.84% <ø> (ø)
web 40.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicholasBlaskey NicholasBlaskey merged commit c811947 into main Mar 21, 2024
79 of 89 checks passed
@NicholasBlaskey NicholasBlaskey deleted the helm_fix_readd branch March 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants