Skip to content

Commit

Permalink
chore: helm for multirm kubeconfig_path (#9033)
Browse files Browse the repository at this point in the history
  • Loading branch information
NicholasBlaskey authored Mar 21, 2024
1 parent 4441d6d commit c811947
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
8 changes: 7 additions & 1 deletion helm/charts/determined/templates/master-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,13 @@ stringData:
{{- if .Values.additional_resource_managers}}
additional_resource_managers:
{{- toYaml .Values.additional_resource_managers | nindent 4}}
{{- range $index, $manager_and_pools := .Values.additional_resource_managers }}
- resource_manager:
{{- omit $manager_and_pools.resource_manager "kubeconfig_secret_name" "kubeconfig_secret_value" | toYaml | nindent 8 }}
kubeconfig_path: {{ include "determined.secretPath" . }}{{ $index }}/{{ required "for each additional_resource_managers, resource_manager.kubeconfig_secret_value must be specified" $manager_and_pools.resource_manager.kubeconfig_secret_value }}
resource_pools:
{{- toYaml $manager_and_pools.resource_pools | nindent 8}}
{{- end }}
{{- end }}
{{- if .Values.resourcePools}}
Expand Down
10 changes: 10 additions & 0 deletions helm/charts/determined/templates/master-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ spec:
mountPath: {{ include "determined.secretPath" . }}
readOnly: true
{{ end }}
{{- range $index, $manager := .Values.additional_resource_managers }}
- name: additionalrm-kubeconfig{{ $index }}
mountPath: {{ include "determined.secretPath" . }}{{ $index }}/
readOnly: true
{{- end }}
{{- if .Values.db.certResourceName }}
- name: database-cert
mountPath: {{ include "determined.secretPath" . }}
Expand Down Expand Up @@ -128,6 +133,11 @@ spec:
secret:
secretName: {{ .Values.tlsSecret }}
{{- end }}
{{- range $index, $manager := .Values.additional_resource_managers }}
- name: additionalrm-kubeconfig{{ $index }}
secret:
secretName: {{ required "for each additional_resource_managers, resource_manager.kubeconfig_secret_name must be specified" $manager.resource_manager.kubeconfig_secret_name }}
{{- end }}
{{- if .Values.db.sslMode }}
- name: database-cert
{{- $resourceType := (required "A valid .Values.db.resourceType entry required!" .Values.db.resourceType | trim)}}
Expand Down

0 comments on commit c811947

Please sign in to comment.