chore: warn about det deploy det-version mistmach #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8994 +/- ##
==========================================
- Coverage 47.51% 47.48% -0.03%
==========================================
Files 1168 1168
Lines 176306 176329 +23
Branches 2353 2353
==========================================
- Hits 83765 83738 -27
- Misses 92383 92433 +50
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hamidzr
changed the title
hamidzr
changed the title
hamidzr
added
the
to-cherry-pick
hamidzr
requested review from
daranday,
a team and
NicholasBlaskey
and removed request for
a team
This reverts commit 390deb1.
hamidzr
requested review from
kkunapuli
and removed request for
NicholasBlaskey
kkunapuli
reviewed
Mar 14, 2024
harness/determined/deploy/gke/cli.py
Outdated
| @@ -224,6 +225,7 @@ def configure_helm(args: argparse.Namespace) -> None: | |||
| helm_dir = Path(args.helm_dir) | |||
| with (helm_dir / "Chart.yaml").open() as f: | |||
| helm_chart = safe_load_yaml_with_exceptions(f) | |||
| warn_version_mistmatch(args.det_version) | |||
There was a problem hiding this comment.
I think this is the only one that doesn't check for args.det_version being None?
e.g.,
if args.det_version is None:
args.det_version = determined.__version__
There was a problem hiding this comment.
aws/cli doesn't either.
I added that only to the ones that had a default in the cli arg definition to keep the behavior the same as before.
kkunapuli
reviewed
Mar 14, 2024
kkunapuli
approved these changes
Mar 14, 2024
|
thanks for the review |
|
why didn't the automerge land this? Does it need a review from the codeowner? @determined-ai/ml-sys-notify |
dai-release bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit f52f43b)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever we add a master config schema change older master binaries would not accept them. This explicitly warns about this situation and recommends using the same version of det deploy for this purpose.
covers:
aws, gke, local, gcp
Test Plan
run the cli for all 4 modalities
the test script 390deb1
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
https://hpe-aiatscale.atlassian.net/browse/GAS-727