Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove panics from rm initialization #8983

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

amandavialva01
Copy link
Contributor

Description

Remove panics from resource manager initialization and replace them with error messages so that it is easier to trace back and handle errors.

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9975

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 47.50%. Comparing base (4ae0987) to head (f4b204b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8983      +/-   ##
==========================================
+ Coverage   47.49%   47.50%   +0.01%     
==========================================
  Files        1167     1167              
  Lines      176285   176292       +7     
  Branches     2352     2352              
==========================================
+ Hits        83732    83755      +23     
+ Misses      92395    92379      -16     
  Partials      158      158              
Flag Coverage Δ
backend 42.64% <12.50%> (+0.05%) ⬆️
harness 64.01% <ø> (-0.01%) ⬇️
web 42.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ster/internal/rm/agentrm/agent_resource_manager.go 47.22% <60.00%> (+0.85%) ⬆️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 20.60% <0.00%> (ø)
master/internal/core.go 2.16% <0.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f4b204b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65ef132b7d61e3000881a91c

Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amandavialva01 amandavialva01 merged commit a22656d into main Mar 11, 2024
72 of 86 checks passed
@amandavialva01 amandavialva01 deleted the amanda/removePanicsRM branch March 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants