style: update harness to eliminate I2041 flake8 errors #8960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
from
5db785c
to
288b747
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8960 +/- ##
==========================================
- Coverage 47.12% 47.07% -0.05%
==========================================
Files 1153 1154 +1
Lines 142358 142272 -86
Branches 2421 2421
==========================================
- Hits 67080 66979 -101
- Misses 75088 75103 +15
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
5 times, most recently
from
794a538
to
d2d7755
Compare
ioga
approved these changes
Mar 25, 2024
| @@ -5,27 +5,30 @@ | |||
| import termcolor | |||
|
|
|||
| from determined import cli | |||
|
|
|||
| # avoid circular import | |||
| from determined.cli import _declarative_argparse as detparse | |||
There was a problem hiding this comment.
if I were making this PR I'd probably do as cli here so the usage looks the same as "standard" one, and then Ryan will look at it and say it's an awful idea and I'd have to change it to something like this. anyhow, disregard this comment.
There was a problem hiding this comment.
Yeah, it's a bit awkward. Another solution would be to refactor parts of this file into _declarative_argparse.py.
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
2 times, most recently
from
b2a9771
to
0047fab
Compare
MikhailKardash
changed the title
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
2 times, most recently
from
435de3a
to
ad2e01d
Compare
azhou-determined
approved these changes
Mar 27, 2024
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
2 times, most recently
from
62d8ad5
to
6301258
Compare
MikhailKardash
force-pushed
the
flake8_namespace_updates
branch
from
61ce7c9
to
dd6a59c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update a lot of imports and variables to solve I2041 flake8 issues.
Test Plan
No testing required
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
MD-13