Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin pandas and ray versions for ray tests #8932

Merged
merged 3 commits into from
Mar 4, 2024
Merged

chore: pin pandas and ray versions for ray tests #8932

merged 3 commits into from
Mar 4, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Mar 1, 2024

https://github.com/search?q=repo%3Aray-project%2Fray+pandas+language%3AText&type=code&l=Text (cherry picked from commit 6d1a596)

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 1, 2024
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 411e42e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e5f69358ff7e000897ca74

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (f997cd8) to head (411e42e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8932   +/-   ##
=======================================
  Coverage   44.41%   44.41%           
=======================================
  Files         721      721           
  Lines      134936   134936           
  Branches     2237     2235    -2     
=======================================
  Hits        59929    59929           
  Misses      74849    74849           
  Partials      158      158           
Flag Coverage Δ
backend 34.20% <ø> (ø)
harness 49.80% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hamidzr hamidzr changed the title pin pandas and ray versions chore: pin pandas and ray versions Mar 1, 2024
@hamidzr hamidzr marked this pull request as ready for review March 1, 2024 20:36
@hamidzr hamidzr requested a review from a team as a code owner March 1, 2024 20:36
@hamidzr hamidzr requested review from rb-determined-ai and ioga and removed request for rb-determined-ai March 1, 2024 20:36
@hamidzr hamidzr self-assigned this Mar 1, 2024
@hamidzr
Copy link
Contributor Author

hamidzr commented Mar 1, 2024

@hamidzr hamidzr assigned ioga and unassigned hamidzr Mar 1, 2024
@hamidzr hamidzr changed the title chore: pin pandas and ray versions chore: pin pandas and ray versions for ray tests Mar 1, 2024
Copy link
Contributor

@ioga ioga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking care of this

examples/features/ports/startup-hook.sh Outdated Show resolved Hide resolved
@hamidzr hamidzr enabled auto-merge (squash) March 2, 2024 00:05
@hamidzr hamidzr assigned hamidzr and unassigned ioga Mar 2, 2024
@hamidzr
Copy link
Contributor Author

hamidzr commented Mar 2, 2024

thanks for the help

@hamidzr hamidzr enabled auto-merge (squash) March 4, 2024 16:42
@hamidzr hamidzr merged commit 60436ea into main Mar 4, 2024
69 of 83 checks passed
@hamidzr hamidzr deleted the hz-ray-pin branch March 4, 2024 16:44
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* avoid pinning pandas for other tests
---------

Co-authored-by: Ilia Glazkov <ilia.glazkov@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants