-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SSO button link target [DET-10171] #8925
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm -- looking forward, we really should have link buttons as part of the ui kit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8925 +/- ##
==========================================
- Coverage 47.17% 42.45% -4.72%
==========================================
Files 1154 840 -314
Lines 175088 136240 -38848
Branches 2237 2235 -2
==========================================
- Hits 82596 57845 -24751
+ Misses 92334 78237 -14097
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit beac348)
Description
See: https://hpe-aiatscale.slack.com/archives/CLCE8D998/p1709221849482189
The link for SSO did not wrap entirely around the button element. This fixes the issue.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket