Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upload test results to datadog #8910

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

djanicekpach
Copy link
Contributor

@djanicekpach djanicekpach commented Feb 27, 2024

Description

INFRAENG-363 is exploring test metrics for Determined-AI. We have a running trial for data dog right now.

Test Plan

Test results flow to DataDog for this branch - Pass

Commentary (optional)

Followed setup instruction but set ddtrace in the requirements rather than doing an ad-hoc pip install.
https://app.datadoghq.com/ci/setup/test?framework=pytest&language=python

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

INFRAENG-363

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.53%. Comparing base (d24b19a) to head (d7d4a07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8910      +/-   ##
==========================================
- Coverage   47.53%   47.53%   -0.01%     
==========================================
  Files        1066     1066              
  Lines      170433   170433              
  Branches     2237     2237              
==========================================
- Hits        81018    81017       -1     
- Misses      89257    89258       +1     
  Partials      158      158              
Flag Coverage Δ
backend 43.35% <ø> (-0.01%) ⬇️
harness 63.69% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d7d4a07
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65de5b3394e54900087eacbc
😎 Deploy Preview https://deploy-preview-8910--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djanicekpach djanicekpach changed the title Test: upload test results to datadog test: upload test results to datadog Feb 27, 2024
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I want to complain about that really long line, but I think I'm the only person in the company who still insists on 80 columns. 👴 And it's nice to group stuff together.

@djanicekpach djanicekpach requested review from dannysauer and a team February 27, 2024 21:19
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved. :D

@djanicekpach djanicekpach force-pushed the djanicek/infraeng-363/dd-upload-test-results branch from 7100b62 to d7d4a07 Compare February 27, 2024 21:59
@rb-determined-ai
Copy link
Member

LGTM

I want to complain about that really long line, but I think I'm the only person in the company who still insists on 80 columns. 👴 And it's nice to group stuff together.

I love 80-length lines. Kids these days don't know what's good.

@djanicekpach djanicekpach merged commit 8af4148 into main Feb 28, 2024
71 of 83 checks passed
@djanicekpach djanicekpach deleted the djanicek/infraeng-363/dd-upload-test-results branch February 28, 2024 18:41
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* upload to data dog for e2e tests

* yaml syntax

* try pytest DD integration

* pytest syntax

* more compiler errors

* move install to install place

* move to test requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants