test: remove redundant (and brittle) assertion #8894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not check twice that the REST API 404ed on a missing workspace. Trust our exception type.
✅ Deploy Preview for determined-ui canceled.
|
wes-turner
requested review from
jgongd and
NicholasBlaskey
and removed request for
jgongd
NicholasBlaskey
approved these changes
Feb 28, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
We should not check twice that the REST API 404ed on a missing workspace. Trust our exception type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not check twice that the REST API 404ed on a missing workspace. Trust our exception type.
Description
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket