-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Genai helm service fix #8885
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8885 +/- ##
==========================================
- Coverage 47.53% 47.52% -0.01%
==========================================
Files 1066 1066
Lines 170248 170248
Branches 2235 2235
==========================================
- Hits 80919 80915 -4
- Misses 89171 89175 +4
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
815efc8
to
49f2862
Compare
release: {{ .Release.Name }} | ||
spec: | ||
ports: | ||
- port: {{ required "A valid Values.genai.messageQueuePort entry required!" .Values.genai.messageQueuePort }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a new field, right? maybe values.yaml needs an update with a commented out example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, we actually removed the examples from the values.yaml when I was talking with @NicholasBlaskey a bit ago: https://github.com/determined-ai/determined/pull/8821/files
The idea being that the values would be confusing to new users and that genai isn't fully released yet.
Instead we have documentation here: https://hpe-ai-solutions-documentation.netlify.app/products/gen-ai/latest/admin/set-up/install-kubernetes/ which I will update to include that parameter
* wip trying new service for redis queue * update the genai helm chart integration to enforce services for all hosts * revert the changes from testing * use clusterip instead
Description
We need to make sure that genai can be populated with the service names from k8s to generalize depending on how the network is set up. This allows us to send a particular host service name to the backend server directly.
We also would like to make sure to not have to make assumptions about the kubernetes cluster having load balancers set up. The genai services have been changed over to use ClusterIP
Test Plan
Validate that when checking the helm deploy that it does not have a
LoadBalancer
for anything other than the determined masterDeploy:
helm install --generate-name . --set maxSlotsPerPod=1 --debug --dry-run
It should not contain
LoadBalancer
in the other services for genaiCommentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket