Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add trigger to abort checkpoint deletion #8878

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Feb 23, 2024

Description

Adds a trigger that avoids deleting checkpoints from the database if they aren't marked as DELETED, indicating their deletion from storage.

Test Plan

CI passes.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-10027

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit de80b45
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65de0e849c073c00083a0894

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (c029327) to head (de80b45).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8878   +/-   ##
=======================================
  Coverage   47.54%   47.55%           
=======================================
  Files        1065     1065           
  Lines      170218   170218           
  Branches     2241     2241           
=======================================
+ Hits        80937    80940    +3     
+ Misses      89123    89120    -3     
  Partials      158      158           
Flag Coverage Δ
backend 43.35% <ø> (ø)
harness 63.82% <ø> (+<0.01%) ⬆️
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@amandavialva01 amandavialva01 force-pushed the amanda/abortCheckpointDelete branch 2 times, most recently from a67adc4 to 1f19c1a Compare February 26, 2024 19:49
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@amandavialva01 amandavialva01 merged commit 9817a4d into main Feb 27, 2024
71 of 87 checks passed
@amandavialva01 amandavialva01 deleted the amanda/abortCheckpointDelete branch February 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants