-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add trigger to abort checkpoint deletion #8878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
amandavialva01
force-pushed
the
amanda/abortCheckpointDelete
branch
from
February 23, 2024 22:59
043e640
to
fb7e4eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8878 +/- ##
=======================================
Coverage 47.54% 47.55%
=======================================
Files 1065 1065
Lines 170218 170218
Branches 2241 2241
=======================================
+ Hits 80937 80940 +3
+ Misses 89123 89120 -3
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
amandavialva01
force-pushed
the
amanda/abortCheckpointDelete
branch
from
February 26, 2024 17:17
d1d19c9
to
9bba3f2
Compare
amandavialva01
force-pushed
the
amanda/abortCheckpointDelete
branch
2 times, most recently
from
February 26, 2024 19:49
a67adc4
to
1f19c1a
Compare
jesse-amano-hpe
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
amandavialva01
force-pushed
the
amanda/abortCheckpointDelete
branch
from
February 27, 2024 16:32
72c8032
to
de80b45
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
amandavialva01
added a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a trigger that avoids deleting checkpoints from the database if they aren't marked as
DELETED
, indicating their deletion from storage.Test Plan
CI passes.
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
DET-10027