Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly source bucket region when using minio #8850

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Feb 15, 2024

Description

Instead of hardcoding the AWS URL whenever attempting to retrieve a bucket's region, instead leverage the endpoint URL when specified, ensuring that when MinIO is used for checkpoint storage the correct endpoint is used.

Test Plan

  • Launch a MinIO server locally
  • Create a bucket & an access key
  • Configure devcluster.yaml to use MinIO for checkpoint storage
  • Confirm that checkpoints are able to successfully be stored & retrieved via master

Commentary (optional)

Automated testing around the use of MinIO as an S3 checkpoint storage option should be put in place.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 15, 2024
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2d988c8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65cfab7ac4f9c8000810fec3
😎 Deploy Preview https://deploy-preview-8850--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba8250a) 47.58% compared to head (2d988c8) 53.76%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8850      +/-   ##
==========================================
+ Coverage   47.58%   53.76%   +6.18%     
==========================================
  Files        1068      653     -415     
  Lines      170264    74736   -95528     
  Branches     2240        0    -2240     
==========================================
- Hits        81016    40182   -40834     
+ Misses      89090    34554   -54536     
+ Partials      158        0     -158     
Flag Coverage Δ
backend 43.02% <ø> (-0.01%) ⬇️
harness 64.11% <ø> (-0.06%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 417 files with indirect coverage changes

@corban-beaird corban-beaird marked this pull request as ready for review February 16, 2024 00:27
@corban-beaird corban-beaird requested a review from a team as a code owner February 16, 2024 00:27
@corban-beaird corban-beaird merged commit e78a4c0 into main Feb 16, 2024
71 of 86 checks passed
@corban-beaird corban-beaird deleted the corban-minio-checkpoint-download branch February 16, 2024 18:56
@corban-beaird corban-beaird added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Feb 21, 2024
dai-release bot pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants