-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly source bucket region when using minio #8850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8850 +/- ##
==========================================
+ Coverage 47.58% 53.76% +6.18%
==========================================
Files 1068 653 -415
Lines 170264 74736 -95528
Branches 2240 0 -2240
==========================================
- Hits 81016 40182 -40834
+ Misses 89090 34554 -54536
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more. |
erikwilson
reviewed
Feb 16, 2024
erikwilson
approved these changes
Feb 16, 2024
carolinaecalderon
pushed a commit
that referenced
this pull request
Feb 19, 2024
corban-beaird
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Feb 21, 2024
dai-release bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
(cherry picked from commit e78a4c0)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of hardcoding the AWS URL whenever attempting to retrieve a bucket's region, instead leverage the endpoint URL when specified, ensuring that when MinIO is used for checkpoint storage the correct endpoint is used.
Test Plan
Commentary (optional)
Automated testing around the use of MinIO as an S3 checkpoint storage option should be put in place.
Checklist
docs/release-notes/
.See Release Note for details.
Ticket