Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error message from backend API for workspace deletion #8848

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Feb 14, 2024

Description

https://hpe-aiatscale.slack.com/archives/CLCE8D998/p1707939243269789

Test Plan

  • Create a workspace with at least one registered model
  • Delete the workpspace and check if the toast shows error message from backend API

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 14, 2024
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 018fd9f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65cd50980f87ff0008bbc60f
😎 Deploy Preview https://deploy-preview-8848--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review February 14, 2024 23:45
@keita-determined keita-determined requested a review from a team as a code owner February 14, 2024 23:45
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba03375) 47.58% compared to head (018fd9f) 42.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8848      +/-   ##
==========================================
- Coverage   47.58%   42.67%   -4.91%     
==========================================
  Files        1068      751     -317     
  Lines      170265   131414   -38851     
  Branches     2240     2240              
==========================================
- Hits        81016    56086   -24930     
+ Misses      89091    75170   -13921     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ebui/react/src/components/WorkspaceDeleteModal.tsx 0.00% <ø> (ø)

... and 317 files with indirect coverage changes

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Feb 15, 2024
@keita-determined keita-determined merged commit 556639d into main Feb 15, 2024
77 of 89 checks passed
@keita-determined keita-determined deleted the fix/delete-workspace-message branch February 15, 2024 17:56
dai-release bot pushed a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants