chore: use npm build for hew #8845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the npm build for hew. previously, we used the github build, which required us to grab hew's dependencies and build on install. this should improve build times as the package is built ahead of time.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8845 +/- ##
==========================================
- Coverage 47.58% 42.67% -4.91%
==========================================
Files 1068 751 -317
Lines 170265 131415 -38850
Branches 2240 2238 -2
==========================================
- Hits 81016 56086 -24930
+ Misses 89091 75171 -13920
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
observed effect: restoring cache + getting dependencies was about 9s + 45s, now up/down to 12s + 25s. |
johnkim-det
approved these changes
Feb 16, 2024
carolinaecalderon
pushed a commit
that referenced
this pull request
Feb 19, 2024
This uses the npm build for hew. previously, we used the github build, which required us to grab hew's dependencies and build on install. this should improve build times as the package is built ahead of time.
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
This uses the npm build for hew. previously, we used the github build, which required us to grab hew's dependencies and build on install. this should improve build times as the package is built ahead of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the npm build for hew. previously, we used the github build, which required us to grab hew's dependencies and build on install. this should improve build times as the package is built ahead of time.
Test Plan
no testing needed -- build should succeed
Commentary (optional)
hewwas already a preexisting package in npm, so this is published under the@hpe.comscope. Because of that, the package is aliased back tohewto make the pr smaller. we can look at switching to@hpe.com/hewlater.Checklist
docs/release-notes/.See Release Note for details.
Ticket
no ticket