-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused SetAllocationName #8829
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8829 +/- ##
=======================================
Coverage 47.84% 47.85%
=======================================
Files 1061 1061
Lines 168144 168120 -24
Branches 2237 2240 +3
=======================================
+ Hits 80445 80446 +1
+ Misses 87541 87516 -25
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont forget slurm. you can do it as a separate pr, pretty sure.
done here https://github.com/determined-ai/determined-ee/pull/1192 @stoksc |
e804240
to
4847b53
Compare
Description
The
SetAllocationMethod
in the ResourceManager interface is not used anywhere, just defined.Remove all definitions to this method -- best practice for tech debt, only keep code that we use in the codebase.
Test Plan
N/a, just don't break existing intg or e2e tests.
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
DET-10149