Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused SetAllocationName #8829

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

carolinaecalderon
Copy link
Contributor

Description

The SetAllocationMethod in the ResourceManager interface is not used anywhere, just defined.
Remove all definitions to this method -- best practice for tech debt, only keep code that we use in the codebase.

Test Plan

N/a, just don't break existing intg or e2e tests.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-10149

@cla-bot cla-bot bot added the cla-signed label Feb 12, 2024
Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4847b53
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65ca96748e7e970008433699

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fff85e3) 47.84% compared to head (4847b53) 47.85%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8829   +/-   ##
=======================================
  Coverage   47.84%   47.85%           
=======================================
  Files        1061     1061           
  Lines      168144   168120   -24     
  Branches     2237     2240    +3     
=======================================
+ Hits        80445    80446    +1     
+ Misses      87541    87516   -25     
  Partials      158      158           
Flag Coverage Δ
backend 43.97% <ø> (+0.03%) ⬆️
harness 64.32% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ster/internal/rm/agentrm/agent_resource_manager.go 19.30% <ø> (+0.43%) ⬆️
master/internal/rm/agentrm/resource_pool.go 26.12% <ø> (+0.48%) ⬆️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 0.00% <ø> (ø)
master/internal/rm/kubernetesrm/resource_pool.go 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget slurm. you can do it as a separate pr, pretty sure.

@carolinaecalderon
Copy link
Contributor Author

The SetAllocationMethod in the ResourceManager interface is not used anywhere, just defined. Remove all definitions to this method -- best practice for tech debt, only keep code that we use in the codebase.

done here https://github.com/determined-ai/determined-ee/pull/1192 @stoksc

@carolinaecalderon carolinaecalderon merged commit d8d9965 into main Feb 13, 2024
102 checks passed
@carolinaecalderon carolinaecalderon deleted the 10149-remove-setallocationname branch February 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants