Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide genai helm values config and fix var name #8821

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

tayritenour
Copy link
Contributor

@tayritenour tayritenour commented Feb 9, 2024

Description

Follow up to #8727. Hide the genai helm block

Also make the extraResourcePoolMetadata consistent with other helm variable names

Test Plan

Should not need specific testing beyond what #8727 specifies.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 9, 2024
Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 522d28e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c69e9ed891240008c0884b

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed61121) 47.81% compared to head (522d28e) 47.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8821      +/-   ##
==========================================
- Coverage   47.81%   47.80%   -0.01%     
==========================================
  Files        1050     1050              
  Lines      167394   167394              
  Branches     2240     2237       -3     
==========================================
- Hits        80032    80031       -1     
- Misses      87204    87205       +1     
  Partials      158      158              
Flag Coverage Δ
backend 43.70% <ø> (+<0.01%) ⬆️
harness 64.32% <ø> (-0.01%) ⬇️
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@tayritenour tayritenour requested a review from ioga February 9, 2024 18:26
@tayritenour tayritenour changed the title chore: make genai helm deployment config commented out by default chore: hide genai helm values config and fix var name Feb 9, 2024
@tayritenour tayritenour merged commit f300d97 into main Feb 10, 2024
74 of 86 checks passed
@tayritenour tayritenour deleted the comment_genai_helm branch February 10, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants