-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deploy GenAI in Helm #8727
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8727 +/- ##
==========================================
+ Coverage 47.72% 53.03% +5.31%
==========================================
Files 1049 633 -416
Lines 167293 72316 -94977
Branches 2241 0 -2241
==========================================
- Hits 79842 38355 -41487
+ Misses 87293 33961 -53332
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -178,7 +178,7 @@ checkpointStorage: | |||
# storage beyond initial testing as most Kubernetes cluster nodes do not have a shared file | |||
# system. | |||
type: shared_fs | |||
hostPath: /checkpoints | |||
hostPath: /tmp/checkpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'm doing this because modern k8s won't let you just create a hostPath somewhere like /
. This is required since the change to use containerd as the default: https://kubernetes.io/blog/2022/02/17/dockershim-faq/ and https://cloud.google.com/container-optimized-os/docs/concepts/disks-and-filesystem
This format is also a little more explicit about what's really happening here and why it's not recommended long term.
helm/charts/determined/templates/genai/genai-persistent-volume-claim.yaml
Outdated
Show resolved
Hide resolved
a470c73
to
d3399e0
Compare
d3399e0
to
c678df1
Compare
d134246
to
17a1ca7
Compare
Co-authored-by: Ilia Glazkov <ilia.glazkov@hpe.com>
72519cb
to
402a254
Compare
GAS-166
Description
Allows us to deploy GenAI in the Determined Helm Chart. This is turned off by default but if a version for GenAI is provided, we will create the deployment and the proxies necessary for it to work.
The user will need to provide a shared drive as either:
.Values.sharedPVCName
.The user's cluster will also need to have access to a100 GPUs to run the chat and fine-tuning.
Test Plan
Release Party:
helm/charts/determined
directory like so:helm template test . --set maxSlotsPerPod=1 --dry-run --debug
genai-deployment
is not presentvalues.yaml
fileCommentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket