Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: condense trial update functions #8808

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

amandavialva01
Copy link
Contributor

Description

Condenses trial update functions into one function that updates the specified fields for a given trial.

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

DET-9993

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ce16000
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c3b4c78d943200082785f9

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c5afb6c) 47.72% compared to head (ce16000) 47.72%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8808   +/-   ##
=======================================
  Coverage   47.72%   47.72%           
=======================================
  Files        1049     1049           
  Lines      167292   167293    +1     
  Branches     2243     2241    -2     
=======================================
+ Hits        79841    79843    +2     
+ Misses      87293    87292    -1     
  Partials      158      158           
Flag Coverage Δ
backend 43.30% <79.16%> (+<0.01%) ⬆️
harness 64.32% <ø> (ø)
web 42.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/trial.go 41.55% <100.00%> (ø)
master/pkg/model/experiment.go 13.63% <100.00%> (+0.71%) ⬆️
master/internal/api_trials.go 52.72% <0.00%> (ø)
master/internal/db/postgres_trial.go 67.33% <78.94%> (+1.14%) ⬆️

... and 3 files with indirect coverage changes

@amandavialva01 amandavialva01 force-pushed the amanda/TrialUpdateFieldsRefactor branch 2 times, most recently from 2484a46 to ffe4407 Compare February 6, 2024 22:54
@amandavialva01 amandavialva01 changed the title chore: refactor trial update functions to one function refactor: condense trial update functions Feb 6, 2024
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amandavialva01 amandavialva01 enabled auto-merge (squash) February 7, 2024 16:50
@amandavialva01 amandavialva01 merged commit a35696d into main Feb 7, 2024
69 of 84 checks passed
@amandavialva01 amandavialva01 deleted the amanda/TrialUpdateFieldsRefactor branch February 7, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants