Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make perf tests only alert on failure #8790

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Fix alerts always happening instead of just happening on failure.

Test Plan

After this lands see if I get pinged.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 329dc69
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65bcf130bb6cc500080325cd

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef656bc) 47.72% compared to head (329dc69) 47.72%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8790      +/-   ##
==========================================
- Coverage   47.72%   47.72%   -0.01%     
==========================================
  Files        1049     1049              
  Lines      167250   167250              
  Branches     2241     2241              
==========================================
- Hits        79814    79813       -1     
- Misses      87278    87279       +1     
  Partials      158      158              
Flag Coverage Δ
backend 43.22% <ø> (-0.01%) ⬇️
harness 64.32% <ø> (ø)
web 42.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@NicholasBlaskey NicholasBlaskey merged commit 17f305f into main Feb 2, 2024
77 of 89 checks passed
@NicholasBlaskey NicholasBlaskey deleted the switch_to_fail_only_for_perf_tests branch February 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants