Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default transport to proxy connection #8767

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: add default transport to proxy connection #8767

merged 1 commit into from
Jan 29, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

https://hpe-aiatscale.slack.com/archives/C02PV33GSN5/p1706202417603839

Test Plan

Run a notebook and make sure we don't see a lot of connections with

netstat -W | awk '{print $5}' | cut -d':' -f1 | sort | uniq -c

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner January 29, 2024 15:29
@cla-bot cla-bot bot added the cla-signed label Jan 29, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 99c910d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b7c5527c56390008a04bd5

stoksc
stoksc approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for using cleanhttp

@NicholasBlaskey NicholasBlaskey merged commit 31f6f99 into main Jan 29, 2024
59 of 80 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_for_tls_transport_proxy branch January 29, 2024 15:53
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
@NicholasBlaskey @maxrussell
fix: add default transport to proxy connection (#8767)
864de8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

@kkunapuli kkunapuli Awaiting requested review from kkunapuli kkunapuli is a code owner automatically assigned from determined-ai/backend

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicholasBlaskey @stoksc