test: performance test CI work #8761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8761 +/- ##
==========================================
- Coverage 47.44% 47.44% -0.01%
==========================================
Files 1046 1046
Lines 166888 166888
Branches 2239 2241 +2
==========================================
- Hits 79185 79182 -3
- Misses 87545 87548 +3
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
NicholasBlaskey
force-pushed
the
perf_tests_in_ci
branch
from
02dcbc5
to
bdcfcfa
Compare
loksonarius
approved these changes
Jan 31, 2024
stoksc
reviewed
Jan 31, 2024
stoksc
approved these changes
Jan 31, 2024
.circleci/real_config.yml
Outdated
| command: python .circleci/scripts/wait_for_perf_migration_upload_results.py | ||
|
|
||
| - when: | ||
| condition: <<parameters.take-snapshot>> |
There was a problem hiding this comment.
maybe call this snapshot-after-migrations
| ), | ||
| // This is a bad endpoint and we know it is bad. | ||
| // No sense in making other endpoints be slowed before we get the fix in | ||
| // https://hpe-aiatscale.atlassian.net/browse/DET-10114 |
There was a problem hiding this comment.
Can we ensure that a ticket is created or a comment is made in one of these tickets to re-enable this test. Although I am assume that was the plan in the ticket anyway, I just don't want us to forget.
julian-determined-ai
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does the infra work for perf tests.
Runs the performance tests on every commit on main and allows running on feature branches.
Also records migration timings. Writes this all to a postgres instance we will eventually hook up to our ci grafana.
Test Plan
Manual, and also we will test a bunch after this lands and adjust any issues we find.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket