-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter value resets when switching column types [WEB-1949] #8731
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8731 +/- ##
==========================================
- Coverage 47.42% 42.33% -5.10%
==========================================
Files 1047 730 -317
Lines 166968 128361 -38607
Branches 2242 2242
==========================================
- Hits 79192 54337 -24855
+ Misses 87617 73865 -13752
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
could you investigate why a subsequent call to the form store would be overwritten? if observables can't handle two update calls next to each other, that indicates a larger issue. |
I've found this doesn't resolve the issue. The |
Description
In the experiment filter UI, switching from a text filter (Name contains "profile") to a numeric filter (metric = _), calls
updateFieldValue(field.id, null);
.Update: the issue isisValid
filters fields for the API calls and for saving inupdateSettings
, so temporary invalid states such asvalue == null
won't be stored, and can get overwritten by previous values. The best option is to separateasJsonString
andasSettingsString
in the new approach.2nd Update: now treating this as a race condition, where anything which updates the form field operators and values, is wrapped in an
Observable.batch
Test Plan
Set a text query (Name contains "val"); experiments are filtered
Change column name to another text column (Searcher Metric); text value is still used for filter
Change column name to a numeric metric (Searcher Metric Value); value becomes blank
Add new filters; there is no error
Searcher Metric Value filter's value can be set to a number
Checklist
docs/release-notes/
.See Release Note for details.