Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move from internal glide-table-grid to v6.0.0 [WEB-1945] #8725

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Jan 22, 2024

Description

After conversation with glide-table-grid maintainer, our changes are resolved as of the recent v6 release.
Updated locations of types in modules

Ongoing issue: the checkbox is rendered in purple for a moment before it switches to the select color

Test Plan

  • Successful web build
  • Interactive table loads correctly
  • Checkmarks work correctly (test on small project such as /det/projects/31/experiments )

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6e4f00e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65aeb84e7a60de00085a83fc
😎 Deploy Preview https://deploy-preview-8725--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (190af1d) 47.26% compared to head (6e4f00e) 42.13%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8725      +/-   ##
==========================================
- Coverage   47.26%   42.13%   -5.13%     
==========================================
  Files        1045      728     -317     
  Lines      166692   128156   -38536     
  Branches     2244     2242       -2     
==========================================
- Hits        78780    54002   -24778     
+ Misses      87754    73996   -13758     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.56% <95.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../react/src/components/ExperimentActionDropdown.tsx 24.35% <100.00%> (ø)
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 10.43% <100.00%> (ø)
...act/src/pages/F_ExpList/glide-table/GlideTable.tsx 16.23% <100.00%> (ø)
...i/react/src/pages/F_ExpList/glide-table/columns.ts 22.69% <100.00%> (ø)
...ct/src/pages/F_ExpList/glide-table/contextMenu.tsx 24.44% <100.00%> (ø)
...lide-table/custom-renderers/cells/checkboxCell.tsx 22.11% <100.00%> (-2.19%) ⬇️
...ble/custom-renderers/cells/experimentStateCell.tsx 12.62% <100.00%> (ø)
...st/glide-table/custom-renderers/cells/linkCell.tsx 31.69% <100.00%> (ø)
...glide-table/custom-renderers/cells/loadingCell.tsx 34.17% <100.00%> (ø)
...lide-table/custom-renderers/cells/progressCell.tsx 47.54% <100.00%> (ø)
... and 9 more

... and 317 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you run npm dedupe before merging this

@mapmeld mapmeld enabled auto-merge (squash) January 22, 2024 18:53
@mapmeld mapmeld merged commit 1c21f6a into main Jan 22, 2024
74 of 85 checks passed
@mapmeld mapmeld deleted the glidemod branch January 22, 2024 18:55
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants