-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move from internal glide-table-grid to v6.0.0 [WEB-1945] #8725
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8725 +/- ##
==========================================
- Coverage 47.26% 42.13% -5.13%
==========================================
Files 1045 728 -317
Lines 166692 128156 -38536
Branches 2244 2242 -2
==========================================
- Hits 78780 54002 -24778
+ Misses 87754 73996 -13758
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you run npm dedupe
before merging this
Description
After conversation with glide-table-grid maintainer, our changes are resolved as of the recent v6 release.
Updated locations of types in modules
Ongoing issue: the checkbox is rendered in purple for a moment before it switches to the select color
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.