Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest@1.2.1 #8718

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: upgrade vitest@1.2.1 #8718

merged 1 commit into from
Jan 19, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jan 19, 2024

Description

WEB-1877
Migration guild: https://vitest.dev/guide/migration.html#migrating-from-vitest-0-34-6

Test Plan

  • Check if all react test cases pass
  • Check if web app is runnable and buildable

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7955fd3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a9c1b1c620ac00087e33c9
😎 Deploy Preview https://deploy-preview-8718--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (faea553) 53.54% compared to head (7955fd3) 42.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8718       +/-   ##
===========================================
- Coverage   53.54%   42.11%   -11.44%     
===========================================
  Files         894      725      -169     
  Lines      146985   128056    -18929     
  Branches     2096     2244      +148     
===========================================
- Hits        78710    53935    -24775     
- Misses      68265    73963     +5698     
- Partials       10      158      +148     
Flag Coverage Δ
harness ?
web 42.56% <ø> (-11.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 465 files with indirect coverage changes

@keita-determined keita-determined marked this pull request as ready for review January 19, 2024 00:48
@keita-determined keita-determined requested a review from a team as a code owner January 19, 2024 00:48
@keita-determined keita-determined merged commit 11e3ba9 into main Jan 19, 2024
81 of 92 checks passed
@keita-determined keita-determined deleted the chore/upgrade-vitest branch January 19, 2024 18:23
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants