fix: use Hew dropdown on FilterGroup [WEB-1938] #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8715 +/- ##
==========================================
- Coverage 51.32% 47.09% -4.24%
==========================================
Files 894 577 -317
Lines 156699 118170 -38529
Branches 2088 2088
==========================================
- Hits 80425 55647 -24778
+ Misses 74779 61028 -13751
Partials 1495 1495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mapmeld
added
the
to-cherry-pick
ashtonG
reviewed
Jan 18, 2024
Comment on lines
93
to
94
| const onItemClick = useMemo( | ||
| () => (key: string) => { |
There was a problem hiding this comment.
please import useCallback instead
There was a problem hiding this comment.
oops, yeah that would be the right way to do it. I was splitting up a useMemo and got carried away
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the dropdown in WEB-1938.
I saw an unrelated bug in FilterForm, where tooltips from the table below appear over the form elements. We can (mostly) avoid this with
e.stopPropagationinonMouseMove.Test Plan
In the experiment filters, click "Add condition group", then in that row, click the "+" to see these two options. Confirm you can add conditions to filter experiments.
Checklist
docs/release-notes/.See Release Note for details.