fix: Update hew for chart fix, avoid error from Typography.Label #8712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapmeld
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8712 +/- ##
==========================================
- Coverage 51.32% 47.09% -4.24%
==========================================
Files 894 577 -317
Lines 156699 118166 -38533
Branches 2088 2088
==========================================
- Hits 80426 55648 -24778
+ Misses 74778 61023 -13755
Partials 1495 1495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkim-det
approved these changes
Jan 18, 2024
dai-release bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
* node and label hotfix * label rows =1 (cherry picked from commit e0e08b6)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* node and label hotfix * label rows =1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses an updated hew to fix a reported issue with the chart: determined-ai/hew#99
Also fixes an issue where a Label with
rows: 1is putting an error in the JS ConsoleTest Plan
Builds successfully, Typography change is valid
Checklist
docs/release-notes/.See Release Note for details.