fix: support CommandState for experiment icon
#8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
keita-determined
requested review from
thiagodallacqua-hpe and
hkang1
and removed request for
thiagodallacqua-hpe
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8709 +/- ##
==========================================
- Coverage 51.32% 47.09% -4.23%
==========================================
Files 894 577 -317
Lines 156699 118175 -38524
Branches 2088 2096 +8
==========================================
- Hits 80423 55656 -24767
+ Misses 74781 61024 -13757
Partials 1495 1495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mapmeld
reviewed
Jan 18, 2024
mapmeld
approved these changes
Jan 18, 2024
hkang1
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Perfect, thank you for fixing @keita-determined ! and thanks for the review @mapmeld
keita-determined
added
the
to-cherry-pick
dai-release bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
* fix: support `CommandState` for experiment icon * fix: add default case (cherry picked from commit dbeb458)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* fix: support `CommandState` for experiment icon * fix: add default case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WEB-1941
We were missing JupyterLab states, so added them for experiment icons
Test Plan
dev.setServerAddress('https://gcloud.determined.ai')TerminatedstateCommentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket