fix: support CommandState for experiment icon (#8709)

* fix: support `CommandState` for experiment icon * fix: add default case
determined-ai · Jan 18, 2024 · dbeb458 · dbeb458
1 parent 83fe474
commit dbeb458
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/webui/react/src/components/ExperimentIcons.tsx b/webui/react/src/components/ExperimentIcons.tsx
@@ -2,11 +2,11 @@ import Icon, { Props as IconProps, IconSize } from 'hew/Icon';
 import React, { useMemo } from 'react';
 
 import { stateToLabel } from 'constants/states';
-import { CompoundRunState, JobState, RunState } from 'types';
+import { CommandState, CompoundRunState, JobState, RunState } from 'types';
 
 interface Props {
   showTooltip?: boolean;
-  state: CompoundRunState;
+  state: CompoundRunState | CommandState;
   size?: IconSize;
   backgroundColor?: React.CSSProperties['backgroundColor'];
   opacity?: React.CSSProperties['opacity'];
@@ -25,11 +25,16 @@ const ExperimentIcons: React.FC<Props> = ({
       case JobState.SCHEDULEDBACKFILLED:
       case JobState.QUEUED:
       case RunState.Queued:
+      case CommandState.Queued:
+      case CommandState.Waiting:
         return { backgroundColor, name: 'queued', opacity, title: stateToLabel(state) };
       case RunState.Starting:
       case RunState.Pulling:
+      case CommandState.Starting:
+      case CommandState.Pulling:
         return { name: 'spin-bowtie', title: stateToLabel(state) };
       case RunState.Running:
+      case CommandState.Running:
         return { name: 'spin-shadow', title: stateToLabel(state) };
       case RunState.Paused:
         return { color: 'cancel', name: 'pause', title: 'Paused' };
@@ -48,9 +53,13 @@ const ExperimentIcons: React.FC<Props> = ({
       case RunState.StoppingCompleted:
       case RunState.StoppingError:
       case RunState.StoppingKilled:
+      case CommandState.Terminating:
         return { color: 'cancel', name: 'spin-shadow', title: stateToLabel(state) };
       case RunState.Canceled:
+      case CommandState.Terminated:
         return { color: 'cancel', name: 'cancelled', title: 'Stopped' };
+      default:
+        return { color: 'cancel', name: 'exclamation-circle', title: 'Unknown State' };
     }
   }, [backgroundColor, opacity, state]);