Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix references on children of "training reference" root #8708

Merged
merged 1 commit into from
Jan 18, 2024
Merged

docs: fix references on children of "training reference" root #8708

merged 1 commit into from
Jan 18, 2024

Conversation

wes-turner
Copy link
Contributor

@wes-turner wes-turner commented Jan 17, 2024 •
edited
Loading

api-det-reference.rst and api-pytorch-reference.rst had each other's tags.

Description

Test Plan

Look at the links on https://docs.determined.ai/latest/reference/training/_index.html

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@wes-turner
docs: fix references on children of "training reference" root
5883456 
api-det-reference.rst and api-pytorch-reference.rst had each other's
tags.
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 5883456
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a854bae624db0008c563ff
😎 Deploy Preview https://deploy-preview-8708--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@determined-ci determined-ci requested a review from a team January 17, 2024 22:29
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jan 17, 2024
@wes-turner wes-turner marked this pull request as ready for review January 17, 2024 22:37
tara-det-ai
tara-det-ai approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! LGTM!

@wes-turner wes-turner merged commit 83fe474 into main Jan 18, 2024
77 of 88 checks passed
@wes-turner wes-turner deleted the wes/docs-reference-root branch January 18, 2024 18:00
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
@wes-turner @maxrussell
docs: fix references on children of "training reference" root (#8708)
80b59b5 
api-det-reference.rst and api-pytorch-reference.rst had each other's
tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wes-turner @tara-det-ai @determined-ci