Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace antd reset.css with modern-normalize #8706

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Jan 17, 2024

Description

In order to remove antd, we want to replace antd/dist/reset.css with something of the similar functionality.
Dependencies tried:
normalize.css - Does not have the style needed
sanitize.css - Works link
modern-normalize - Works link

modern-normalize is chose over sanitize.css due to it's more actively maintained and also has smaller size.

Test Plan

Navigate through pages on different browsers (chrome, safari, firefox) and check that styles are expected.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1921

@gt2345 gt2345 requested a review from a team as a code owner January 17, 2024 21:59
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit bdf98c6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a84dcc7692960008fd6576
😎 Deploy Preview https://deploy-preview-8706--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7dc7aa) 51.32% compared to head (bdf98c6) 47.09%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8706      +/-   ##
==========================================
- Coverage   51.32%   47.09%   -4.24%     
==========================================
  Files         894      577     -317     
  Lines      156699   118166   -38533     
  Branches     2088     2088              
==========================================
- Hits        80423    55648   -24775     
+ Misses      74781    61023   -13758     
  Partials     1495     1495              
Flag Coverage Δ
harness ?
web 53.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 317 files with indirect coverage changes

@gt2345 gt2345 merged commit 71eaa5a into main Jan 18, 2024
81 of 92 checks passed
@gt2345 gt2345 deleted the gt/1921-replace-reset.css branch January 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants