chore: TrialsComparisonModal style fixes [WEB-1919] [WEB-1909] #8674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
==========================================
- Coverage 51.51% 47.32% -4.19%
==========================================
Files 887 570 -317
Lines 156209 117679 -38530
Branches 2088 2088
==========================================
- Hits 80466 55693 -24773
+ Misses 74250 60493 -13757
Partials 1493 1493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mapmeld
requested review from
keita-determined
and removed request for
johnkim-det
mapmeld
force-pushed
the
compare_trials
branch
from
af8e559
to
90483f2
Compare
|
@keita-determined good catch! I selected more experiments in Uncategorized so that the issue would be visible. Then I added a z-index css rule to the top-left table header (adding z-index to the button did not help) |
|
I think this new z-index gives us the right order of z-index es The left column cannot be visible in the top left unless we made a special case for dropdowns 
|
mapmeld
force-pushed
the
compare_trials
branch
from
4e013f5
to
be17113
Compare
mapmeld
force-pushed
the
compare_trials
branch
from
be17113
to
1b9438d
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses an Antd / UI Kit ticket, plus a bug ticket, around the
TrialsComparisonModalantd.TagwithRowcontainingLabeland close icon buttoncolSpanto cover multiple experiments or multiple trialIds (+1 to include original column)As used in multi-trial experiment trials table:
As used in the experiments Glide Table:
Test Plan
Open a multi-trial experiment such as
/det/experiments/1290/trials. Check to select multiple trial rows. In the action menu, select Compare trials to open the modalOpen a project such as
/det/projects/1/experiments. Check multiple successful / completed experiments which can be compared.Open the Compare section using the button at top right of the table.
In the Compare section, click the Details tab to see the table as used here
Checklist
docs/release-notes/.See Release Note for details.